Skip to content

DPL Analysis: easy way to filter a table on the fly - #4929

Merged
jgrosseo merged 1 commit into
AliceO2Group:devfrom
aalkin:selector-method
Dec 2, 2020
Merged

DPL Analysis: easy way to filter a table on the fly#4929
jgrosseo merged 1 commit into
AliceO2Group:devfrom
aalkin:selector-method

Conversation

@aalkin

@aalkin aalkin commented Nov 26, 2020

Copy link
Copy Markdown
Member

@jgrosseo @saganatt I've realized there is an easier way to filter a table on-the-fly

@aalkin
aalkin requested review from a team, iarsene and jgrosseo as code owners November 26, 2020 11:55
@saganatt

Copy link
Copy Markdown
Collaborator

Nice! :-)

Comment thread Framework/Core/include/Framework/ASoA.h Outdated
@ktf

ktf commented Nov 26, 2020

Copy link
Copy Markdown
Member

Don't we have select(tracks, expressions) already? If not, can we add that as well?

@aalkin

aalkin commented Nov 26, 2020

Copy link
Copy Markdown
Member Author

Don't we have select(tracks, expressions) already? If not, can we add that as well?

You mean as an external function? We have

template <typename T>
auto filter(T&& t, framework::expressions::Filter const& expr)

though it is not used anywhere.

UPD: I fixed the filter function to work just like select.

@jgrosseo

Copy link
Copy Markdown
Collaborator

This is very nice!
Can we move it to a different tutorial though? We are using the full histograms for benchmarking, and I don't like to change it so that we can keep a full evolution of the time needed as a function of release tag.
You can add it to the histograms one instead (or a new one) if you want

Comment thread Framework/Core/include/Framework/ASoA.h Outdated
@aalkin

aalkin commented Nov 26, 2020

Copy link
Copy Markdown
Member Author

@jgrosseo what do you think of the new example?

@jgrosseo

Copy link
Copy Markdown
Collaborator

I guess this is what we should use as well for the MC associations...

@jgrosseo
jgrosseo merged commit 4fd3147 into AliceO2Group:dev Dec 2, 2020
@aalkin
aalkin deleted the selector-method branch December 16, 2020 09:19
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants